plone.restapi icon indicating copy to clipboard operation
plone.restapi copied to clipboard

add cache rules for @site and @navroot

Open mamico opened this issue 1 year ago • 4 comments

there are no caching rule for @site and @navroot.

Is it intentional omission or oversight?

mamico avatar May 07 '24 20:05 mamico

@mamico thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mister-roboto avatar May 07 '24 20:05 mister-roboto

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 1062d54171c31eba5806ad5bffb9c33c5bd00c7f
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/663b3d492981df0009a5c8c9

netlify[bot] avatar May 07 '24 20:05 netlify[bot]

there are no caching rule for @site and @navroot.

Is it intentional omission or oversight?

It wasn't intentional at all.

erral avatar May 08 '24 06:05 erral

@jenkins-plone-org please run jobs

mamico avatar May 08 '24 08:05 mamico