plone.restapi icon indicating copy to clipboard operation
plone.restapi copied to clipboard

Add UID to the metadata for summaries, for example related items.

Open mauritsvanrees opened this issue 2 years ago • 3 comments

Fixes https://github.com/plone/plone.restapi/issues/1585

TODO: fix tests.

mauritsvanrees avatar Feb 16 '23 15:02 mauritsvanrees

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mister-roboto avatar Feb 16 '23 15:02 mister-roboto

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit b12a6d191fdb83bedd2b293e57cd8f1a92e1531b
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/63ee4f16d395740008d73e59

netlify[bot] avatar Feb 16 '23 15:02 netlify[bot]

Note: This was added for serialized RelationValues in https://github.com/plone/plone.restapi/pull/1605. I think this change is probably still desirable, in order to include the UID in other places that use the summary serializer. But the tests need to be fixed.

davisagli avatar May 09 '23 05:05 davisagli