plone.restapi icon indicating copy to clipboard operation
plone.restapi copied to clipboard

Fix the category of the 'Users and groups settings' controlpanel adapter

Open sneridagh opened this issue 2 years ago • 8 comments

Fixes: #1482

sneridagh avatar Sep 01 '22 11:09 sneridagh

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 7f877b6a8ecc2a86d9426ff569691f4ccab3153b
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/6310a73865521b0009dce5a6

netlify[bot] avatar Sep 01 '22 11:09 netlify[bot]

@sneridagh thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mister-roboto avatar Sep 01 '22 11:09 mister-roboto

This is /controlpanel What's wrong on your side? Please provide some more info here or in an issue. image

ksuess avatar Sep 01 '22 11:09 ksuess

This is /controlpanel

backend Plone 6 current beta frontend Volto branch master

ksuess avatar Sep 01 '22 11:09 ksuess

@ksuess my bad, I documented it in the issue: https://github.com/plone/plone.restapi/issues/1482

sneridagh avatar Sep 01 '22 11:09 sneridagh

I put an effort to get things right when adding the group membership control panel. But, yes, will check what's going wrong.

ksuess avatar Sep 01 '22 11:09 ksuess

Volto side fix: https://github.com/plone/volto/pull/3603

sneridagh avatar Sep 01 '22 11:09 sneridagh

I put an effort to get things right when adding the group membership control panel. But, yes, will check what's going wrong.

All good, as said, it seems that the category was not ok. TBH I've been there as well, the mapping between classic and restapi handling is not intuitive and error prone. :(

sneridagh avatar Sep 01 '22 12:09 sneridagh

@jenkins-plone-org please run jobs

sneridagh avatar Sep 01 '22 13:09 sneridagh

@jenkins-plone-org please run jobs

sneridagh avatar Sep 01 '22 19:09 sneridagh