plone.restapi icon indicating copy to clipboard operation
plone.restapi copied to clipboard

Add test that tests the redirector behavior of plone.restapi

Open tisto opened this issue 2 years ago • 7 comments

tisto avatar Apr 06 '22 19:04 tisto

@tisto thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mister-roboto avatar Apr 06 '22 19:04 mister-roboto

@ericof @sneridagh I wrote a test to prove that plone.restapi behaves in a wrong way when re-using a plone.app.redirector redirect. Though, it turns out the test passed. I just proved that it also works like this in real life. I have no clue why this didn't work before.

tisto avatar Apr 06 '22 19:04 tisto

@tisto I "fixed" the test, now it proves there is an infinite loop

ericof avatar Apr 06 '22 20:04 ericof

A PR is open on plone.rest

ericof avatar Apr 06 '22 21:04 ericof

@tisto released it, however, then should we make p.restapi depend on p.rest 2.0.0a5 as minimum requirement?

sneridagh avatar Apr 07 '22 09:04 sneridagh

@sneridagh Plone 6 should depend on p.rest 2.0.0a5, right?

ericof avatar Apr 07 '22 11:04 ericof

@sneridagh @ericof I'd prefer to avoid hard requirements in setup.py. They cause lots of trouble for everyone who is using buildout. I'd prefer to pin the newer versions in our buildout and in the released Plone versions.

tisto avatar Apr 07 '22 14:04 tisto

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 69920d7c8473ffa6c7c3db126e17bdd1e56e5ca3
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64e5ca826f0e3300087c0a08

netlify[bot] avatar Aug 23 '23 08:08 netlify[bot]

@sneridagh @ericof I am totally out of the loop here. Is that test something we want in plone.restapi or shall we close the issue?

tisto avatar Aug 23 '23 09:08 tisto

@tisto The issue was fixed in plone.rest and a similar test added there. I don't think we need a copy of the test here.

davisagli avatar Aug 23 '23 16:08 davisagli