plone.restapi
plone.restapi copied to clipboard
Add test that tests the redirector behavior of plone.restapi
@tisto thanks for creating this Pull Request and helping to improve Plone!
TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
@jenkins-plone-org please run jobs
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.
Happy hacking!
@ericof @sneridagh I wrote a test to prove that plone.restapi behaves in a wrong way when re-using a plone.app.redirector redirect. Though, it turns out the test passed. I just proved that it also works like this in real life. I have no clue why this didn't work before.
@tisto I "fixed" the test, now it proves there is an infinite loop
A PR is open on plone.rest
@tisto released it, however, then should we make p.restapi depend on p.rest 2.0.0a5 as minimum requirement?
@sneridagh Plone 6 should depend on p.rest 2.0.0a5, right?
@sneridagh @ericof I'd prefer to avoid hard requirements in setup.py. They cause lots of trouble for everyone who is using buildout. I'd prefer to pin the newer versions in our buildout and in the released Plone versions.
Deploy Preview for plone-restapi canceled.
Name | Link |
---|---|
Latest commit | 69920d7c8473ffa6c7c3db126e17bdd1e56e5ca3 |
Latest deploy log | https://app.netlify.com/sites/plone-restapi/deploys/64e5ca826f0e3300087c0a08 |
@sneridagh @ericof I am totally out of the loop here. Is that test something we want in plone.restapi or shall we close the issue?
@tisto The issue was fixed in plone.rest and a similar test added there. I don't think we need a copy of the test here.