plone.restapi
plone.restapi copied to clipboard
plone
move translations into plone.app.locales
Fixes #841
Merge together:
- https://github.com/collective/plone.app.locales/pull/332
- https://github.com/plone/buildout.coredev/pull/743
@erral thanks for creating this Pull Request and help improve Plone!
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.
Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
@jenkins-plone-org please run jobs
With this simple comment all the jobs will be started automatically.
Happy hacking!
I agree with @mauritsvanrees here. Though, plone.restapi 9 is not planned to be Plone 6 only. I would prefer to keep Plone 5.2 and Plone 6 compatibility for a while, at least until Plone 6 is really stable and has a final release. In the end, this is a tradeoff between having to merge lots of fixes and features back and forth between multiple branches (7,8,9) or live with the fact that the translations will stay in plone.restapi for a while. Since the translations are pretty stable and the other options means lots of additional work, I would strongly suggest that we wait with this until we have other strong reasons for cutting a Plone 6 only plone.restapi release.
I saw this item in the Plone 6 release to-do list and that's because I took it, but I see your points.
We can do what @mauritsvanrees says or just leave as it is, close the PRs and recover them when we are ready.,
@erral yeah. Sorry, my fault! I did not think about the implications of this move. We can create a milestone Plone6-only and merge this PR when it is ready.
This one is completely outdated, since there are only a few locales left in plone.restapi. close?
This PR was cancelled. Should we close the related PRs as well then?
- https://github.com/collective/plone.app.locales/pull/332
- https://github.com/plone/buildout.coredev/pull/743
