plone.restapi
plone.restapi copied to clipboard
Refactor @lock endpoint based on CRUD operations and add it to expandable @components
| Verb | URL | Action |
|---|---|---|
| POST | /@lock | Lock an object |
| GET | /@lock | Current lock information |
| PATCH | /@lock | Refresh lock |
| DELETE | /@lock | Remove lock |
We should also be able to use expand=lock in order to easily get locking information in one Rest API call.
@tisto @sneridagh @tiberiuichim thoughts?!
+1 looks good, seems semantic.
@avoinea this makes sense to me. Though, we have to be aware that this is a breaking change and requires a new major release. I saw that you kept the old code to be backward compatible. This might be a way to go to avoid a major release.
Though, the question is if this effort does make sense. I could imagine that not lots of people are using this anyways. Maybe it is cleaner to make a breaking release and get rid of the old code altogether. Just thinking out loud here...
@tisto As we will need to cherry-pick it in 7.x I think is best to do it in 2 steps, first deprecate, then drop it and major release :wink:
@avoinea right. We won't be able to drop the functionality in the 7.x branch (at all).
@avoinea could you image to work on a PR for master that removes the old lock endpoint behavior for plone.restapi 9? I'd like to have a set of PRs ready once we are ready to move on to version 9 (with Plone 6).
@tisto I think that's an easy one. :beer: