plone.docker icon indicating copy to clipboard operation
plone.docker copied to clipboard

Add arm64 support

Open pnicolli opened this issue 2 years ago • 4 comments

Just tracking it here, it would be awesome to have this here even if plone/plone-backend exists, since this is still used and is still the official library image.

I have no idea about where to go in order to add the arm64 build in the official library. Any pointers? Also, I was looking at the github actions here. I assume the builds are pushed manually to docker hub, are they @avoinea ?

pnicolli avatar Aug 05 '22 20:08 pnicolli

@pnicolli Nope, they are not. See https://github.com/docker-library/official-images/blob/master/library/plone

And an update PR https://github.com/docker-library/official-images/pull/11795/files

And the ARM architectures where remove by:

  • https://github.com/docker-library/official-images/pull/11303/files
  • https://github.com/docker-library/official-images/pull/11291/files

avoinea avatar Aug 06 '22 07:08 avoinea

@pnicolli If you have the possibility to build and test the images on ARM architectures we can re-include them when we do the PR to official-images for #168 and #169

avoinea avatar Aug 06 '22 07:08 avoinea

@pnicolli Would be nice if we would be able to test on ARM via github actions :exploding_head:

avoinea avatar Aug 06 '22 07:08 avoinea

@pnicolli Nope, they are not. See https://github.com/docker-library/official-images/blob/master/library/plone

And an update PR https://github.com/docker-library/official-images/pull/11795/files

Yeah sorry, my question was about the unofficial images plone/plone, but I just realized they are not kept up to date, which is also fine.

@pnicolli If you have the possibility to build and test the images on ARM architectures we can re-include them when we do the PR to official-images for https://github.com/plone/plone.docker/issues/168 and https://github.com/plone/plone.docker/issues/169

I will let you know if I can look into this, I recently moved to a newer arm powered laptop.

@pnicolli Would be nice if we would be able to test on ARM via github actions 🤯

I believe this is doable, I will try

pnicolli avatar Aug 07 '22 20:08 pnicolli