Insert Image / Upload tab wording unclear about required sequence of actions

[tkimnguyen]

/cc @plone/ux-team

• [ ] Once you browse to specify an image to upload (or you drag it into the drop zone) it's not clear that you have to press the Upload button next.

• [ ] After you press the Upload button, the image you uploaded disappears out of the drop zone, and it's not clear that you have to click over to the Internal Image tab to see the uploaded image

• [ ] In the Internal Image tab, you then may have to re-search the site to find the image you just uploaded, then you have to click on it then click the Insert button

[domruf]

with 247b92228640bd0d184dc4a3abf4a092d2126ffe the dialog switches to Internal Link again

[frapell]

Maybe for the first point, when an image is selected / dropped, the Upload button could turn Green or something?

@domruf That means that when the upload finishes, the tab is switched back to the "internal image" and also the image is already selected?

[domruf]

@frapell yes. vangheem originally did this back in august 4ae86f0face4b1ea8998c38a70b430e6ea95fdf5 But it didn't work anymore. With my fix in 247b922 it works again.

[domruf]

Is there a reason not to automatically upload and select the image when somebody clicks the insert button?

If not I will submit a pull request for that.

[frapell]

The only reason I can imagine is if you fat fingered the image and select an incorrect one.

If you take Dropbox for example, it will start uploading right away after choosing the image, but if you chose an incorrect one, you can remove it in few clicks.

If you upload an incorrect image using the "Insert image" from tinymce when editing a document, it means you will need to stop editing, go to the image and remove it.

I think in this case, it is ok to have to manually click upload after choosing the image. It would be great if the UI team can come up with a design for users to intuitively understand this

[vangheem]

For me on coredev, it is still automatically selecting the image you just uploaded. It just doesn't flip back to the right tab automatically for you.

I'm indifferent about automatically uploading immediately after you select a file.

We probably should try having a robot test for this...

[domruf]

@vangheem you are right. The image was selected but since it was not visible in the dialog it was a bit confusing.

My idea was that the upload would start after clicking the insert button, not directly after selecting/dropping a file. That I think would be a bit premature.