documentation icon indicating copy to clipboard operation
documentation copied to clipboard

update installing_addons.rst

Open dgroos opened this issue 6 years ago • 5 comments

Integrated a "note" into the prior sentence where the info was needed, streamlining sentences so that it was brief yet clear.

Thank you for your contribution to the Plone Documentation.

Before submitting this PR, please make sure:

Fixes: #

Improves:

Changes proposed in this pull request:

dgroos avatar Dec 01 '19 04:12 dgroos

@dgroos would you please update the PR, so that we can merge it.

MrTango avatar Apr 13 '22 06:04 MrTango

@dgroos would you please update the PR, so that we can merge it.

Or we need to take over here...

jensens avatar Apr 13 '22 09:04 jensens

First time contributor, no contributions anywhere else since 2019, I would say, yes, take over.

stevepiercy avatar Apr 13 '22 09:04 stevepiercy

Please do. Or wait till this weekend and I can figure out how to do it. Thanks

On Wed, Apr 13, 2022 at 4:23 AM Jens W. Klein @.***> wrote:

@dgroos https://github.com/dgroos would you please update the PR, so that we can merge it.

Or we need to take over here...

— Reply to this email directly, view it on GitHub https://github.com/plone/documentation/pull/1107#issuecomment-1097785761, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7INX43DNFEF32KLRY5HDLVE2G7ZANCNFSM4JTJWOYA . You are receiving this because you were mentioned.Message ID: @.***>

dgroos avatar Apr 13 '22 12:04 dgroos

We don't have permission to publish this contribution. See https://6.docs.plone.org/contributing/documentation/index.html#granting-permission-to-publish.

If we don't get permission from @dgroos then we can reconstruct the PR or just close it as "won't fix". I prefer the former option.

stevepiercy avatar Mar 31 '24 13:03 stevepiercy

@jensens @MrTango is this PR's content acceptable?

If it is, then I can reconstruct the PR under my GitHub username, as we do not have permission from @dgroos to publish it.

stevepiercy avatar Apr 28 '24 20:04 stevepiercy

line 143/144 change is fine. Below those I am not sure. I would keep it as-is.

jensens avatar Apr 28 '24 22:04 jensens

Done in 4ebf668ae504f540deabb16972422ba886c3ec38 on 5.2 and 303494c3eb8c5e815422b574b040d3a2c7fc816c and f656c94f0b31f16ffe08fb910d5dba72e374edb6 on 5.2-myst. Closing.

stevepiercy avatar Apr 28 '24 22:04 stevepiercy