Numsense icon indicating copy to clipboard operation
Numsense copied to clipboard

Published 20 hours ago • verified publisher icon ploeh

Add Lithuanian language

Open dvitonis opened this issue 9 years ago • 4 comments

  • Parses both feminine and masculine basic numerals in the nominative singular case.
  • Converts numbers to masculine basic numerals in the nominative singular case.

dvitonis avatar Jan 31 '16 11:01 dvitonis

CLA assistant check
All committers have accepted the CLA.

CLAassistant avatar Jan 31 '16 11:01 CLAassistant

Thank you for your interest in contributing to Numsense. The overall code looks promising, and it compiles without warnings on my machine, and all tests pass :+1:

I pointed out a few issue that I think might be worth considering, but it's hardly anything major.

ploeh avatar Feb 02 '16 13:02 ploeh

It builds and runs all tests without warnings on my machine, so from a technical perspective I think we're good to go :+1:

As I don't read Lithuanian, I'd like someone who does to review that part of it, if at all possible. I don't expect any errors, but it's always good with a second pair of eyes :smile:

ploeh avatar Feb 03 '16 20:02 ploeh

I solicited a review on Twitter: https://twitter.com/ploeh/status/694983221189156865

Please retweet and spread the word :smile:

ploeh avatar Feb 03 '16 20:02 ploeh