Numsense
Numsense copied to clipboard
ploeh
Add Slovak language
Numbers are spaced out, which is not 100% grammatically correct. It should be easy to adapt should you decide that you want to support the "compact" form as well.
Slovak numerals are declinable, which means that if toSlovak was parametrizable with the grammatical case and gender, the various forms could be generated on demand.
Any plans to implement parsers/generators for ordinal numbers?
Thank you for your interest in contributing to Numsense. The code looks good, and it compiles without warnings on my machine, and all tests pass :+1:
Numbers are spaced out, which is not 100% grammatically correct. It should be easy to adapt should you decide that you want to support the "compact" form as well.
We're having a discussion on a similar topic about the Spanish contribution. Is this something that makes sense to take into account here as well?
Slovak numerals are declinable, which means that if toSlovak was parametrizable with the grammatical case and gender, the various forms could be generated on demand.
We could make it parametrisable. Danish and English doesn't make the distinction, but I'm aware that other languages do. We had a similar discussion about Russian, but here we decided that it wouldn't constrain further options to start with only the masculine form. This option may or may not be reasonable for Slovak; you tell me :smile:
Any plans to implement parsers/generators for ordinal numbers?
Not at the moment.
Given the quality of the code, I'd be happy to proceed. The next step would then be a language review from someone who reads Slovak.
In light of all of the above, though, is there anything you want to change, or should we proceed with the language review?
We're having a discussion on a similar topic about the Spanish contribution. Is this something that makes sense to take into account here as well?
It does. With that said, I think that it would be fine to merge this as is. Once it has been decided on how to approach the problem, I could revisit this in a different PR. You'd have to be a language purist to be offended by this :)
We had a similar discussion about Russian, but here we decided that it wouldn't constrain further options to start with only the masculine form.
It will be a fairly large undertaking to introduce cases, but I can't say whether the structure of the code would have to go through a major overhaul or not at this point. (I would not want to see a complete Finnish implementation :laughing:)
Unless you're of a different opinion, I'd have it reviewed in the current state. I'll be happy to push this further in the future.
As I don't read Slovak, I'd like someone who does to review that part of it, if at all possible. I don't expect any errors, but it's always good with a second pair of eyes :smile:
I solicited a review on Twitter: https://twitter.com/ploeh/status/694537645456756736
Please retweet and spread the word :smile: