Numsense icon indicating copy to clipboard operation
Numsense copied to clipboard

Published 20 hours ago • verified publisher icon ploeh

Added Chinese

Open kfazi opened this issue 9 years ago • 5 comments

I've added traditional and simplified Chinese with normal and financial variants. Please keep in mind I'm not a Chinese native speaker and it would be great if somebody could check my text for correctness.

Also I'm just starting with F# and any comments how can I improve my code are very welcome :smiley:

kfazi avatar Jan 11 '16 20:01 kfazi

Thank you for your interest in contributing to Numsense. FTR, I'm currently travelling, and have only limited to time to evaluate pull requests. In due time, I'll work through my backlog, but it may take weeks :flushed: :sweat:

ploeh avatar Jan 12 '16 19:01 ploeh

I've removed unneeded useAlternativeTwo parameter.

kfazi avatar Jan 26 '16 16:01 kfazi

@ploeh: Thanks for CR :smiley: I've just fixed issues you reported.

kfazi avatar Jan 29 '16 16:01 kfazi

It builds and runs all tests without warnings on my machine, so from a technical perspective I think we're good to go :+1:

As I don't read Chinese, I'd like someone who does to review that part of it, if at all possible. I don't expect any errors, but it's always good with a second pair of eyes :smile:

ploeh avatar Jan 31 '16 17:01 ploeh

I solicited a review on Twitter: https://twitter.com/ploeh/status/693845849370169346

Please retweet and spread the word :smile:

ploeh avatar Jan 31 '16 17:01 ploeh