Peter L Jones

Results 563 comments of Peter L Jones

> Coding Style Check / Verify Python coding style (pull_request) Why did that fail? ---- https://github.com/jamulussoftware/jamulus/issues/3408 raised.

> I have the feeling that documentation is lacking on explaining the code. I feel unsure about the exact functionality - especially the cli parsing. Which documentation? What are you...

It's probably best if @AndersGoran comments.

So if I've got five sliders assigned and I always want slide 1 to be "me", I'd expect 2, 3, 4 and 5 to be someone else, agreed. I'd also...

> Lookup table sounds more performant and less messy. Yup - the current version uses a lookup table. However you do it, you need to cater for both the situation...

> How the user would add plugins The normal way is some kind of "scan" of well known locations (these are documented on the linked site), plus user-configurable paths, plus...

Yes. I've got to check a gew other places too see where else I did it, too.

Some items to pick up when reviewing the release process: > - [x] Check ./Jamulus -h output against the [Include-Client](https://github.com/jamulussoftware/jamuluswebsite/blob/next-release/wiki/en/Include-Client-Commands.md)/[Server-Commands](https://github.com/jamulussoftware/jamuluswebsite/blob/next-release/wiki/en/Include-Server-Commands.md).md pages and [man page (distributions/Jamulus.1)[(https://github.com/jamulussoftware/jamulus/blob/main/distributions/Jamulus.1). Update if necessary. "https://github.com/jamulussoftware/jamuluswebsite/blob/next-release/wiki/en/Include-Server-Commands.md" --...

Another change request for the changelog-helper: ``` $ grep SKIP ./tools/changelog-helper.sh if [[ "${title_suggestion_in_pr}" == "SKIP" ]]; then ``` Could do with this issuing a message. I got ``` Checking...

> - [ ] Finish App translations > - [ ] Review translation PRs according to [release process checklist](https://jamulus.io/contribute/Release-Process#3-update-the-ts-files-returned-by-translators) > - [ ] Wait for all PRs to be merged...