plivo-node icon indicating copy to clipboard operation
plivo-node copied to clipboard

Client Options is typed as string instead of an object

Open schmidlidev opened this issue 11 months ago • 1 comments

The API documentation says that an options object can be passed to the client:

var plivo = require('plivo');
let options = {
	'timeout': 50000, //ms
	'host': 'https://proxyurl',
	'port': 'proxyport',
	auth: {
		username: 'my-user',
		password: 'my-password'
	}
}

var client = new plivo.Client("<auth_id>", "<auth_token>", options);

However, in typescript options is typed as string rather than an object (or even just any). https://github.com/plivo/plivo-node/blob/master/types/rest/client.d.ts#L10

schmidlidev avatar Feb 29 '24 16:02 schmidlidev

This is fixed in this PR by @narayana-plivo

huzaif-plivo avatar Mar 01 '24 05:03 huzaif-plivo