plivo-node
plivo-node copied to clipboard
plivo
Typescript fixes
Hello!
We're in the process of upgrading our version of plivo-node ahead of the January 31st deprecation.
We use typescript and noticed that the typescript signatures don't appear to match the underlying API.
The numbers search endpoint appears to have a bug.
The numbers buy and update endpoints appear to make the appId a required parameter when it's not strictly required by the API (we tested it without and it work fine). If appId is required, it means that you cannot prepurchase numbers.
Let me know if you have any questions? Thanks!!
I would appreciate an urgent response as we can't test the migration of our application until this is resolved. Thanks!
hi @bxjx we would like to understand how number search, buy and rent is working for you in the current setup with plivo-node and what's the version you are currently using?
hi @bxjx we would like to understand how number search, buy and rent is working for you in the current setup with plivo-node and what's the version you are currently using?
@apoorv-plivo we were using a fork of 0.4.1.
The main thing is that we need to buy numbers without having to specify an app ID. We pre purchase numbers and then later assign them to applications.
@bxjx Understood. So as per your current implementation, you are passing app ID while renting/updating the number? We wanted to confirm this as we believe this issue would be there in your existing implementation and is not specific to upgrade.
@bxjx we have merged these changes and included these in the latest version v4.26.1 release.