hub icon indicating copy to clipboard operation
hub copied to clipboard

Implement Certificate Revocation List

Open Danielius1922 opened this issue 5 months ago • 2 comments

This pull request includes several changes to the certificate authority's codebase, focusing on improving the handling of signing records and enhancing documentation. The most important changes include adding validation for CredentialStatus, updating documentation to reflect the new functionality, and correcting typographical errors.

Code Enhancements:

  • certificate-authority/pb/signingRecords.go: Added a Validate method to CredentialStatus to ensure all necessary fields are populated and correctly formatted.
  • certificate-authority/pb/signingRecords.go: Refactored Validate method in SigningRecord to use the new CredentialStatus validation.

Documentation Updates:

  • certificate-authority/pb/README.md: Updated descriptions for GetSigningRecords and DeleteSigningRecords to reflect the new functionality of revoking certificates. Added fields serial and issuer_id to the documentation. [1] [2] [3]
  • certificate-authority/pb/doc.html: Updated HTML documentation to include new fields and corrected descriptions for GetSigningRecords and DeleteSigningRecords. [1] [2] [3]

Typographical Corrections:

  • certificate-authority/pb/service.proto: Corrected typos in comments for GetSigningRecords and DeleteSigningRecords. [1] [2]
  • certificate-authority/pb/service.swagger.json: Corrected typos in the Swagger documentation for GetSigningRecords and DeleteSigningRecords. [1] [2]

Minor Changes:

  • .dockerignore: Added test-local to the ignore list.
  • certificate-authority/config.yaml: Removed bulk write configuration settings.

These changes collectively enhance the robustness of the certificate authority's functionality and improve the clarity of its documentation.

Danielius1922 avatar Sep 23 '24 14:09 Danielius1922