plfa.github.io icon indicating copy to clipboard operation
plfa.github.io copied to clipboard

document .gitignore. Add .DS_Store to it while at it.

Open JacquesCarette opened this issue 1 year ago • 2 comments

As per title.

JacquesCarette avatar Aug 28 '24 16:08 JacquesCarette

So it seems to pre-commit hook didn't like my changes to .gitignore. Are the rules to obey written down somewhere?

JacquesCarette avatar Aug 28 '24 17:08 JacquesCarette

The pre-commit setup sorts it alphabetically, which is incorrect given that .gitignore exclusions and inclusions are order-dependent, so that should probably be taken out.

(The details are in the pre-commit config file. Follow the links to the various repositories to find out what code each action runs.)

wenkokke avatar Aug 29 '24 09:08 wenkokke

This one is ready for review @wenkokke .

JacquesCarette avatar Jul 26 '25 19:07 JacquesCarette

I meant after their respective inclusions, eg, the zip inclusion after the general exclusion, but that's alright, we can fix that later.

wenkokke avatar Jul 26 '25 21:07 wenkokke