Cmake fails to run on Linux Mint 18.3 (Ubuntu 16.04 LTS)

[clintolsen]

I'm current at git tag v2.38.0.999-e14e4d74-5-g970544b

Platform: Gigabyte BRIX i5-4200 w/Linux Mint 18.3 (Ubuntu 16.04 LTS)

I installed the requirements: mpv, ffmpeg, Qt 5.9.5

Running cmake, I get:

~/Downloads/plex-media-player/build$ cmake -DCMAKE_BUILD_TYPE=Debug DQTROOT=$QT_BASE_DIR -DCMAKE_INSTALL_PREFIX=/usr/local ..

[5 bytes data]

  GET
  /directdl/plex-dependencies/plexmediaplayer-qt/206/konvergo-qt--release-206d4d1.tbz2.sha.txt
  HTTP/1.1

  Host: nightlies.plex.tv

  User-Agent: curl/7.47.0

  Accept: */*



  [5 bytes data]

  The requested URL returned error: 404 Not Found

  Closing connection 0

It's really difficult to discern what's relevant and what isn't. It looks like CMakeError.log just has configuration test errors not real problems, but let me know if it's necessary to upload them.

[mseeley]

Could this be QT_ROOT? These matching issues sound very familiar: https://github.com/plexinc/plex-media-player/search?q=QTROOT&type=Issues.

If so, would you submit a PR or suggest a relevant edit to our documentation? It looks like something we've hit disappointingly frequently and haven't documented.

[clintolsen]

My $QT_BASE_DIR is /opt/qt59 and this directory exists, so I have no idea what the problem is with my QT_ROOT argument.

[mseeley]

I see DQTROOT in your paste above. Should this be -DQT_ROOT?

[clintolsen]

Hah, indeed you are correct! Sorry, I totally missed the typo. Thanks, this was pilot error!

[mseeley]

@clintolsen how's this look for a documentation diff:

diff --git a/README.md b/README.md
index 45ea397..3b172fd 100644
--- a/README.md
+++ b/README.md
@@ -18,7 +18,7 @@ If you're happy just building from the command line then run CMake for the ninja
 * Install mpv and other dependencies with homebrew:
   * ``brew install mpv --with-shared --HEAD``
 * ``mkdir build ; cd build``
-* ``cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=output ..``
+* ``cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=output -DQT_ROOT={directoryContainingQt} ..``
 
 Build (ninja):
 
@@ -52,9 +52,9 @@ Systems not based on Debian/Ubuntu will have similar packages, but you'll need t
 
 ### Downloading and installing Qt
 
-If your distro provides a Qt 5.9.5 package, try to use it. Otherwise, download a supported Qt version from qt.io.
+If your distro provides a Qt 5.9.5 package, try to use it. Otherwise, download a supported Qt version from qt.io. Make sure you include `-DQT_ROOT={directoryContainingQt}` when running `cmake`.
 
-On Windows and OSX, you can omit the ``-DQTROOT`` argument to use the Qt built by Plex. (Untested whether this works reliably.)
+On Windows and OSX, you can omit the ``-DQT_ROOT`` argument to use the Qt built by Plex.
 
 ### Building mpv and ffmpeg
 

[clintolsen]

I think this looks good. It would be good if cmake barfed out an intelligible message when it can't find QT. For example, right after that I didn't have MPV installed, so it emitted messages indicating it couldn't find it.