plex-for-kodi icon indicating copy to clipboard operation
plex-for-kodi copied to clipboard

Better/own PlayerProcessInfo implementation

Open pannal opened this issue 7 years ago • 6 comments

GHI (If applicable): #

Description:

Adds PMS stream/decision details to the PlayerProcessInfo window; PlayerProcessInfo directly implemented in SeekDialog

This ultimately supersedes #218

Checklist:

  • [x] I have based this PR against the develop branch

pannal avatar Jul 09 '18 17:07 pannal

I still need to review the code, but this looks awesome!

I noticed I'm not always getting video info - the line isn't visible. This either needs to show below the OSD, or hide when the OSD is visible, as it covers the preview images.

You might as well change the 'o' key handler to use this:

                 elif action.getButtonCode() == 61519:
-                    # xbmc.executebuiltin('Action(PlayerProcessInfo)')
-                    xbmc.executebuiltin('Action(CodecInfo)')
+                    if self.getProperty('show.PPI'):
+                        self.hidePPIDialog()
+                    else:
+                        self.showPPIDialog()

ruuk avatar Jul 10 '18 00:07 ruuk

OK, this is reviewable now.

The session data seems to only be available for the user that owns the server, so the PMS stream detail part doesn't work on a friends' server nor when the current user is a managed user.

pannal avatar Jul 10 '18 15:07 pannal

This now works with non-owned servers as well, by taking partial data from the transcodeSession if available.

pannal avatar Jul 11 '18 15:07 pannal

Done.

pannal avatar Jul 13 '18 16:07 pannal

Rebased onto develop

pannal avatar Aug 13 '18 14:08 pannal

Rebased

pannal avatar Aug 28 '18 23:08 pannal