plex-for-kodi icon indicating copy to clipboard operation
plex-for-kodi copied to clipboard

Add vertical round robining for dialogs where it fits

Open pannal opened this issue 6 years ago • 4 comments

GHI (If applicable): #

Description:

Add round robining on dialog(s) where it makes sense. Unify episodes view options dropdown behaviour by closing it on left instead of top.

Checklist:

  • [x] I have based this PR against the develop branch

pannal avatar Jul 06 '18 01:07 pannal

This was broken due to a typo. Re-pushed.

pannal avatar Jul 06 '18 20:07 pannal

I only think wrapping lists make sense for long lists.

ruuk avatar Jul 10 '18 01:07 ruuk

I disagree. Wrapping makes sense for any list with more than two items, that doesn't close by pressing UP.

Here's why: Navigating a UI daily in my case leads to me knowing the position of every control in every list. I know that "Go to TV Shows" is at the bottom of the three-dot-dropdown inside the episode window. I don't even have to think about that, press the three-dot-dropdown, up and OK and am where I want to be.

I don't see any reason why we wouldn't do this; also I'd strongly suggest not doing this for long lists only, because if the user detects wrapping in lists, he expects it in every list and gets annoyed otherwise.

Edit: This isn't exclusive to me, when using a remote to navigate, people develop a kind of UI-muscle-memory.

pannal avatar Jul 10 '18 12:07 pannal

Rebased onto develop

pannal avatar Aug 13 '18 14:08 pannal