FastMM4 icon indicating copy to clipboard operation
FastMM4 copied to clipboard

Published 20 hours ago • verified publisher icon pleriche

Magic Numbers

Open maximmasiutin opened this issue 8 years ago • 3 comments

There are some Magic Numbers in FastMM4

https://en.wikipedia.org/wiki/Magic_number_(programming)#Unnamed_numerical_constants

For a single author, it is OK, but for a public open source code -- I think we should little by little name them.

maximmasiutin avatar Jun 16 '17 21:06 maximmasiutin

I've removed almost all magic numbers in the fork https://github.com/maximmasiutin/FastMM4-AVX

This fork is well-tested already, used in The Bat! email client www.ritlabs.com/en/products/thebat/ , and it is much faster.

maximmasiutin avatar Nov 14 '17 10:11 maximmasiutin

I've removed almost all magic numbers in the fork https://github.com/maximmasiutin/FastMM4-AVX

Shouldn't you do a Pull Request with this?

EMBBlaster avatar Nov 14 '17 13:11 EMBBlaster

Unfortunately, there were no single commit with just magic numbers removed, the changes were very significant; namely, in alignment, in thread locking and in AVX instructions. So, there will be impossible to just make a pull request. But it will be possible to just compare the files and introduce the changes manually.

maximmasiutin avatar Nov 15 '17 14:11 maximmasiutin