Allow no decimals

[darylteo]

In reference to #82.

This feature turned up in one of my client work today, so I figured I'd try to implement it myself (spare time, unsponsored :( )

This patch introduces the allowNoDecimal property (false by default).

By turning it on the follow semantics apply:

• values are initially treated as integer
• any numbers added are automatically thousand'd.
• the first time a decimal is placed, the number is now treated as a float
• further attempts to insert a decimal is ignored
• you may add up to precision number of digits after the decimal
• if adding a decimal indicator to, or masking an, existing value causes an over-precision, the rest are discarded.
• if adding a digit to the left of the decimal indicator, it is treated as part of the integral portion of the value, and is added properly (UNTESTED, see below).

Both the precision and the decimal properties influences this behaviour (so if decimal is changed to ",", the "," key must be used to start decimals).

I hope these semantics make sense, as I will be using these in my client project.

I have also updated the Readme, the demo html, as well as introduced 4 new tests for testing this behaviour. Unfortunately I could not get "." and cursor keypresses to work in the test :( if you let me know how to get them to work, I'll add more tests.

Kind Regards, Daryl

[darylteo]

btw amazed that this feature is 2 years late =) thanks for the plugin.

[darylteo]

Ah... unmasked fails, because it depends on specific number of segments in the string. ( I think you mentioned this in another pull request I spotted). Troublesome. Without knowing which decimal indicator is being used in the unmasked method, this becomes difficult. Will mull.

Edit: ahh... unmasked doesn't even require the field to be initialised, so even if I did depend on data attributes, it may not even be there... can we make this a, you know, requirement? What use case would we have to call maskMoney on a field that isn't initialised? (and I ask this because all the tests in unmasked_test.js do not initialise maskMoney)

[gbass84]

There's a couple options here, but I think the easiest to merge and maintain is to explicitly write the config properties to the masked element when masking. This can't be done with .data(), because that data is stored internally in jQuery, and the element loses it's reference to it. I think the best thing to do is use .attribute() or the vanilla equivalent.

On 3/11/15 5:09 AM, Daryl Teo wrote:

Ah... unmasked fails, because it depends on specific number of segments in the string. ( I think you mentioned this in another pull request I spotted). Troublesome. Without knowing which decimal indicator is being used in the unmasked method, this becomes difficult. Will mull.

— Reply to this email directly or view it on GitHub https://github.com/plentz/jquery-maskmoney/pull/165#issuecomment-78243985.

[darylteo]

I did not know that! You leant something new everyday.

Yes I agree if jQuery data doesn't put the attribute on the element the setup is a little strenuous... I'll modify it when I have the time today.

This doesn't solve the question of whether unmasked method can be called on non-initialized input fields, for the time being. But maybe this discussion can lead us there.

On Thursday, March 12, 2015, Graham Bass [email protected] wrote:

There's a couple options here, but I think the easiest to merge and maintain is to explicitly write the config properties to the masked element when masking. This can't be done with .data(), because that data is stored internally in jQuery, and the element loses it's reference to it. I think the best thing to do is use .attribute() or the vanilla equivalent.

On 3/11/15 5:09 AM, Daryl Teo wrote:

Ah... unmasked fails, because it depends on specific number of segments in the string. ( I think you mentioned this in another pull request I spotted). Troublesome. Without knowing which decimal indicator is being used in the unmasked method, this becomes difficult. Will mull.

— Reply to this email directly or view it on GitHub < https://github.com/plentz/jquery-maskmoney/pull/165#issuecomment-78243985 .

— Reply to this email directly or view it on GitHub https://github.com/plentz/jquery-maskmoney/pull/165#issuecomment-78290113 .

[pojda]

Anything new on this?