sass-export
sass-export copied to clipboard
plentycode
Inline comments fix and packages update
I have updated the node-sass package in order to be able to parse things like sass map-get. I've also added regex to remove both multiline and inline comments
Nice work @ihorbond , I hope the project owner will merge this soon. Any idea if the sass package instead of the node-sass package will work as well?
Sorry @ihorbond for the late reply, thanks for the nice work, would you take a look at the failing unit tests https://travis-ci.org/github/plentycode/sass-export/jobs/714598510?
@ihorbond, i've checked your PR and it seems that the group annotation comments are also removed by the REGEX you've added in the getContent() method. By removing these comments this package doesn't function properly anymore and thus the tests fail. A little background: it seems that all variables are grouped inside the export. By using the group annotation comments you can group the variables. Because the annotation marks are removed, all variables are placed inside the default group.
In the tests they also test the existence of other groups besides the default variables one, and thus the test fail.
Hi @civan , I would like to ask you if you could look into my PR #63 . sass-export is still downloaded 5000 times a week via NPM. So at least updating the dependencies would really help the people out here to use this niche plugin a little longer. Looking forward to your response!
sorry guys @Levdbas @civan didn't see this got traction. I could just remove the line with regex for now to make the tests pass