ngx-popover icon indicating copy to clipboard operation
ngx-popover copied to clipboard

package.json compatible with Angular 4

Open istreeter opened this issue 7 years ago • 8 comments

I would like to update my app to angular 4, which is backwards compatible with angular 2. Currently I cannot update by I get this error message:

npm WARN [email protected] requires a peer of @angular/core@^2.0.0 but none was installed.

This can be fixed by changing peerDependencies to "^2.0.0 || ^4.0.0"

It would be great if you could accept this pull request so that I can update my app whilst still using ngx-popover.

istreeter avatar May 24 '17 14:05 istreeter

Same here. Thank you in advance.

deskenazi avatar May 31 '17 17:05 deskenazi

Ya, we need this too. Thanks!

jonnysamps avatar May 31 '17 19:05 jonnysamps

Yes please

guan01 avatar May 31 '17 19:05 guan01

That would be great !

HFlorina avatar May 31 '17 20:05 HFlorina

Really needed, hope it will be merged soon :)

WillyReyno avatar Jun 21 '17 15:06 WillyReyno

Hey all, just wanted to point out that the README states pretty clearly that this repo will NOT be maintained. So I wouldn't hold out hope.

jonnysamps avatar Jun 21 '17 16:06 jonnysamps

Yeah, I noticed that after I made the pull request. So I found this fork to use instead: https://github.com/ctubio/ng4-popover. I'm leaving this pull request open just in case.

istreeter avatar Jun 21 '17 16:06 istreeter

Hi how can i append popover to body? I tried data-container='body' but it not working!

masoudline avatar Nov 19 '17 22:11 masoudline