Pleco icon indicating copy to clipboard operation
Pleco copied to clipboard

Compile `pleco_engine` with stable Rust

Open sfleischman105 opened this issue 6 years ago • 2 comments

The following features need to be stabilized before pleco_engine can compile on stable:

For benchmarking:

  • [x] test (Switched to Criterion with #92 )

Dependency stabilization

  • [ ] lazy_static nightly (no current tracking issue)
  • [ ] pleco needs to be usable on stable as defined by #76 .

sfleischman105 avatar Jan 30 '18 06:01 sfleischman105

error[E0554]: #![feature] may not be used on the stable release channel
  --> C:\Users\alexa\.cargo\registry\src\github.com-1ecc6299db9ec823\prefetch-0.2.0\src\lib.rs:18:1
   |
18 | #![feature(link_llvm_intrinsics)]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error 

So what version or branch of rust should one be using?

looak avatar Mar 15 '19 14:03 looak

@looak currently, nightly rust is required to use pleco. I'll double check though to make sure it still compiles on nightly.

I'll look into having a 'nightly' feature flag for pleco. I think most of the unstable features aren't exactly needed, but are there for mostly speed / convenience.

sfleischman105 avatar Mar 23 '19 22:03 sfleischman105