rororo icon indicating copy to clipboard operation
rororo copied to clipboard
verified publisher icon playpauseandstop

Update to latest openapi-core

Open 93578237 opened this issue 3 years ago • 3 comments

#149 So, it cannot be updated to v0.14.2 due to missing some features (like RequestValidator._get_headers), so we should wait for the next release

TODO:

  • [ ] Update typing
  • [ ] SecurityError handling: it checks all available authentication methods of the operation, and raises InvalidSecurity from openapi-core, if no one passes. So Idk how to properly raise rororo security errors, using new openapi-core api
  • [ ] 2 tests are not yet passed: tests/rororo/test_openapi.py::test_optional_security_scheme. Response headers always dont have the auth header

93578237 avatar Jan 13 '22 22:01 93578237

@q0w

Thanks for this initiative! One question though, do you think using latest unreleased openapi-core version is good idea? I'd start with migration to openapi-core==0.14.2, if this possible...

playpauseandstop avatar Jan 14 '22 10:01 playpauseandstop

@playpauseandstop as I mentioned earlier, v0.14.2 contains some todos in actual code. I think we should wait for the next openapi-core release. Could you explain pls why response contains auth headers in tests/rororo/test_openapi.py::test_optional_security_scheme and how it works in current rororo

93578237 avatar Jan 14 '22 18:01 93578237

@q0w

Thanks a lot for this attempt! I, for sure, will take a deeper look here, when will implement #149 and ensure openapi-core==0.17.1 support for rororo==4.0

playpauseandstop avatar May 29 '23 20:05 playpauseandstop