markdown-editable-textinput icon indicating copy to clipboard operation
markdown-editable-textinput copied to clipboard

Added better links creation

Open jesusrp98 opened this issue 4 years ago • 2 comments

This PR adds the ability to set the URL directly using this package.

jesusrp98 avatar Oct 08 '20 13:10 jesusrp98

Hi @jesusrp98, thanks for your PR on our package. Unfortunatly however, I can't see the utility of what you did, as the user isn't prompt to set the link anywhere in the app, resulting in the link to be null (instead of having the same content for the text and the link). Can you explain what you wanted to do with this ?

clemenceroumy avatar Dec 04 '20 08:12 clemenceroumy

@clemenceroumy I'm using this new link parameter to more easily create the link markdown-friendly. I found that with the current implementation is a bit more finicky.

Here are some photos & code snippets about my current use:

image image image

onTap(MarkdownType.link, link: link);

FormatMarkdown.convertToMarkdown(
      type,
      textFieldcontroller.text,
      textSelection.baseOffset,
      textSelection.extentOffset,
      titleSize: titleSize,
      link: link,
    );

jesusrp98 avatar Dec 15 '20 11:12 jesusrp98

Hi @jesusrp98 based on your work and what you proposed, we've done a change to the package in order to add a modal to insert a link.

The PR https://github.com/playmoweb/markdown-editable-textinput/pull/32 has been merged and will be available in the next version.

Thanks for your work and sorry for the huge delay.

clemenceroumy avatar Jan 03 '23 10:01 clemenceroumy