twirl icon indicating copy to clipboard operation
twirl copied to clipboard

Published 20 hours ago • verified publisher icon playframework

Fix problems regarding Scala 3 and sourcePositionMapper

Open mkurz opened this issue 2 years ago • 3 comments

See

  • https://github.com/playframework/twirl/pull/461#issuecomment-1066378493
  • https://github.com/lampepfl/dotty/issues/14691
  • https://github.com/sbt/zinc/issues/1074#issuecomment-1073247308

Following commit could then be reverted eventually: https://github.com/playframework/twirl/commit/e892f83f9b97a56cddafd50e59bd88f9bbaf8557

mkurz avatar Mar 28 '22 22:03 mkurz

The pull request I sent to sbt/zinc has been merged. Hopefully, the next release will fix the problem.

tototoshi avatar Apr 11 '22 14:04 tototoshi

@tototoshi Nice :+1: BTW, did you see https://github.com/sbt/sbt/discussions/6868, I didn't look into all of that, however has this something to do with our problem?

mkurz avatar Apr 12 '22 13:04 mkurz

Yes, I am interested in this proposal. I don't think that this proposal can be a solution to our problem with sourcePositionMappers. However, it will be a help to make Twirl error messages more friendly in the future.

tototoshi avatar Apr 15 '22 12:04 tototoshi