[1769] fix the tag so user's input is not cleared as it was stored in flash so ...

[deanhiller]

Let me know if I should separate this into two pull requests(I just thought it was soo simple that I put both fixes in one pull request).

1. ability to customer errorClass so we can match twitter bootstrap error class
2. fix the tag so it reads from flash and displays what the user had typed in previously.

[deanhiller]

I think this is pretty much my last pull request by the way(everything else is working for us).....I do need to get back to the logback pull request and rework that one still.

Dean

[cloudbees-pull-request-builder]

play-1-3-x-pull-requests #126 SUCCESS This pull request looks good

[Notalifeform]

Hi @deanhiller
Pleease separet them and add a test for the field issue (as requested on lighthouse). Thanks,

Robert

[deanhiller]

test case added.

[cloudbees-pull-request-builder]

play-1-3-x-pull-requests #130 SUCCESS This pull request looks good

[pepite]

The problem with 2. is that some people do not want to have it automatically (because they might use something else than the Flash object). You can alway define your own tag...

[deanhiller]

hmmmm, I am confused. We follow the documentation I thought pretty much to the T using the "field" tag everywhere and our end users are very upset about all their forms always being cleared. This also means everyone's forms are being cleared on play websites and their users are probably not too happy as well.

Can I at least get a brand new tag then? I would think most users would want to use the brand new tag over the old one as when they follow the docs for the new tag, then they get desired end user behavior.

I could be completely wrong as I don't know other ways of filling in the information of the field? What are the other ways? I just went by following play documentation and it did'nt work the way end users expected and was deleting their data.

[pepite]

Maybe making it possible to overwrite the value will do actually. Let me think about it

[cloudbees-pull-request-builder]

play-1-3-x-pull-requests #141 SUCCESS This pull request looks good

[deanhiller]

cool, happy to hear it. If there is anything else I can do....more work on this one.....or something else.... just let me know.

thanks, Dean