What happened to OrderBy support in simplified JPA queries?

[jvosloo]

In 1.5.1 at least, the support for OrderBy in simplified JPA queries seems to be missing? I.e. to be able to write simplified queries like this: Person.find("byNameOrderByName");

If I read this right: https://play.lighthouseapp.com/projects/57987/tickets/878-orderby-support-in-simplified-queries it was introduced in 1.3.x already?

Am I missing something?

[jvosloo]

?

[asolntsev]

@jvosloo Wow. You found The Lost Change. :)

Support for OrderBy was added in commit https://github.com/playframework/play1/commit/b91659a7 - at that time it was in master branch.

Later, we found that master branch is not up-to-date with some other release branches. Me and @xael-fry decided that master was not in valid state, and renamed it to old_master. So we lost commit b91659a7. :)

@xael-fry It seems that we need to merge 3 commits with commit message [#878] ... from master_old to master.

[jvosloo]

Hehe... glad I could be helpful (and sorry for making more work for you!) 😄

[xabolcs]

@xael-fry , @jvosloo

I tried my best in PR #1343 to port those commits to master.

[xabolcs]

@jvosloo please check recent master!

My PR just landed, thanks to @xael-fry!