play-ws icon indicating copy to clipboard operation
play-ws copied to clipboard

async-http-client 3.0.0 (was 2.12.3)

Open scala-steward opened this issue 1 year ago • 4 comments

About this PR

📦 Updates org.asynchttpclient:async-http-client from 2.12.3 to 3.0.0

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.asynchttpclient", artifactId = "async-http-client" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.asynchttpclient", artifactId = "async-http-client" }
}]
labels: library-update, early-semver-major, semver-spec-major, commit-count:1

scala-steward avatar Jul 29 '24 23:07 scala-steward

So... async-http-client v3 drops netty-reactive-streams, so this needs some work probably. e.g the shading will not be necessary anymore. See comments in

  • #863

Related

  • #915

mkurz avatar Jul 30 '24 14:07 mkurz

As a heads up @mkurz ...

AHC 3

  • drops OAuth ( https://github.com/AsyncHttpClient/async-http-client/pull/1902 )
  • drops Stream Handling ( https://github.com/AsyncHttpClient/async-http-client/pull/1843 | https://github.com/AsyncHttpClient/async-http-client/discussions/1925 )
  • migrates to Duration
    • https://github.com/AsyncHttpClient/async-http-client/issues/1861
    • https://github.com/AsyncHttpClient/async-http-client/pull/1862
    • https://github.com/AsyncHttpClient/async-http-client/pull/1864
    • https://github.com/AsyncHttpClient/async-http-client/pull/1865
    • https://github.com/AsyncHttpClient/async-http-client/pull/1866

Not an huge effort to port it if one uses the good old battle axe... But would mean dropping OAuth 1 / Streaming Future (unless one invests into an alternative stream handler)

Nezisi avatar Nov 18 '24 21:11 Nezisi

Side note: we can remove the scala pin afterwards: https://github.com/playframework/play-ws/blob/152c072dbc712e165b26e0dc908df4ecd3376d49/.github/scala-steward.conf#L5-L7

mkurz avatar Feb 25 '25 10:02 mkurz

@Nezisi would you be interested in providing a PR to upgrade async-http-client to version 3 in this repo?

mkurz avatar Jul 17 '25 22:07 mkurz