play-ws icon indicating copy to clipboard operation
play-ws copied to clipboard

Update build

Open cchantep opened this issue 3 years ago • 5 comments

cchantep avatar Mar 11 '22 11:03 cchantep

Formatting issue:

scalafmt: /home/runner/work/play-ws/play-ws/project/Dependencies.scala isn't formatted properly!

mkurz avatar Mar 11 '22 12:03 mkurz

Akka-Stream is published for Scala 3, but not Akka-HTTP, and due to inter-dependency, one cannot be _2.13 and the other _3, otherwise raise class loading issue.

[error]  org.specs2.specification.core.FatalExecution: akka.actor.ExtensionId.$init$(Lakka/actor/ExtensionId;)V (Http.scala:845)
[error] akka.http.scaladsl.Http$.<clinit>(Http.scala:845)
``

cchantep avatar Mar 11 '22 22:03 cchantep

Looks like akka-http is only used in integration-tests/src/test; is it really needed?

SethTisue avatar Mar 11 '22 23:03 SethTisue

disable integration-tests if Scala 3 🤔

diff --git a/build.sbt b/build.sbt
index ea2426a..03a2033 100644
--- a/build.sbt
+++ b/build.sbt
@@ -393,6 +393,15 @@ lazy val `integration-tests` = project
   .settings(publish / skip := true)
   .settings(
     Test / fork := true,
+    Test / sources := {
+      if (scalaBinaryVersion.value == "3") {
+        // TODO akka-http for Scala 3
+        // https://github.com/akka/akka-http/issues/3891
+        Nil
+      } else {
+        (Test / sources).value
+      }
+    },
     concurrentRestrictions += Tags.limitAll(1), // only one integration test at a time

xuwei-k avatar Mar 12 '22 02:03 xuwei-k

disable integration-tests if Scala 3 🤔

diff --git a/build.sbt b/build.sbt
index ea2426a..03a2033 100644
--- a/build.sbt
+++ b/build.sbt
@@ -393,6 +393,15 @@ lazy val `integration-tests` = project
   .settings(publish / skip := true)
   .settings(
     Test / fork := true,
+    Test / sources := {
+      if (scalaBinaryVersion.value == "3") {
+        // TODO akka-http for Scala 3
+        // https://github.com/akka/akka-http/issues/3891
+        Nil
+      } else {
+        (Test / sources).value
+      }
+    },
     concurrentRestrictions += Tags.limitAll(1), // only one integration test at a time

Rather wait akka-http

cchantep avatar Mar 12 '22 13:03 cchantep

since akka-http with scala3 will only be released with BSL License, how can we move this forward? using the BSL version just for the tests is okay?

jtjeferreira avatar Nov 20 '22 00:11 jtjeferreira