play-ws icon indicating copy to clipboard operation
play-ws copied to clipboard

Add Scala 3 support

Open SethTisue opened this issue 3 years ago • 9 comments

would a volunteer like to attempt this? it would be helpful even just to have a failing draft PR that shows where the next roadblock is, and then we could chip away it from there

I published ssl-config and cachecontrol today for Scala 3, so that helps

#590 should be merged before any attempt is made at this

SethTisue avatar Aug 04 '21 00:08 SethTisue

@SethTisue As you probably have noticed, #590 got merged.

mkurz avatar Aug 11 '21 19:08 mkurz

@xuwei-k Do you can/want to help?

mkurz avatar Aug 15 '21 17:08 mkurz

Could not compile play-ws with Scala 3 due to https://github.com/lampepfl/dotty/issues/12731 😢

https://github.com/playframework/play-ws/blob/c8429038edce378626996467f33301a7c1b2ad03/play-ws-standalone/src/main/scala/play/api/libs/ws/StandaloneWSRequest.scala#L23

xuwei-k avatar Aug 16 '21 02:08 xuwei-k

I thought this was very clever of me at the time (it was mostly actually Adriaan)

wsargent avatar Aug 17 '21 03:08 wsargent

@xuwei-k @SethTisue did you see these 2 comments? Replacing F-bounds by intersection types? WDYT? Also see https://github.com/lampepfl/dotty/issues/13133 and https://github.com/lampepfl/dotty/issues/10638#issuecomment-739151145

If you have an F-bounded type T <: F[T] simply replace it with T. Then everywhere T is used, replace it with T & F[T].

mkurz avatar Aug 30 '21 06:08 mkurz

https://github.com/playframework/play-ws/pull/604

xuwei-k avatar Aug 30 '21 23:08 xuwei-k

@mkurz I'm sorry but I don't know what to think about that, and I don't feel that have time to dig into it. :-/

SethTisue avatar Sep 07 '21 20:09 SethTisue

@SethTisue Currently not so much time as well (coming weeks)...

mkurz avatar Sep 07 '21 20:09 mkurz

Was implemented in #604 but has some comments https://github.com/playframework/play-ws/pull/604#pullrequestreview-906492465 from @mkurz

ihostage avatar Apr 16 '22 19:04 ihostage

🎉

  • https://github.com/playframework/play-ws/releases/tag/2.2.0-M2
  • https://repo1.maven.org/maven2/com/typesafe/play/play-ws-standalone_3/

xuwei-k avatar Oct 05 '22 08:10 xuwei-k