play-ws icon indicating copy to clipboard operation
play-ws copied to clipboard
verified publisher icon playframework

add proxy

Open wsargent opened this issue 5 years ago • 12 comments

Fixes

  • Fixes https://github.com/playframework/play-ws/issues/418

Purpose

  • Adds ProxyType to Scala API.
  • ProxyServer is missing entirely from Java API, so adding.

wsargent avatar Feb 25 '20 18:02 wsargent

Is this something somebody still wants to try and push forward...?

SethTisue avatar Aug 04 '21 18:08 SethTisue

@SethTisue I completely forgot I wrote this. Lemme review it for sanity :-)

wsargent avatar Aug 12 '21 13:08 wsargent

Okay updated

wsargent avatar Aug 12 '21 14:08 wsargent

Yay! Now, who wants to review this...?

SethTisue avatar Aug 12 '21 17:08 SethTisue

I don't even know who's committer on play-ws now.

wsargent avatar Aug 17 '21 03:08 wsargent

usual suspects we could try and summon: @mkurz, @ignasi35, @octonato

SethTisue avatar Aug 17 '21 04:08 SethTisue

(I'd also be willing to just shrug and hit "merge" myself if no reviewers appear and if you believe the change to be safe.)

SethTisue avatar Aug 17 '21 04:08 SethTisue

@wsargent can you please rebase? Thanks!

mkurz avatar Nov 01 '23 07:11 mkurz

@mkurz done!

wsargent avatar Nov 04 '23 21:11 wsargent

@wsargent CI complaining:

  • https://github.com/playframework/play-ws/actions/runs/6757141380/job/18367413012?pr=473#step:10:25 You need to run headerCreateAll
  • https://github.com/playframework/play-ws/actions/runs/6757141380/job/18367411133?pr=473#step:5:33 You need to add the MiMa filters here: https://github.com/playframework/play-ws/blob/d0119fda6d28e0b732c5706bb939c01c700065de/build.sbt#L56-L57

Thanks!

mkurz avatar Nov 06 '23 10:11 mkurz