play-ws icon indicating copy to clipboard operation
play-ws copied to clipboard

Make nullable getters use Optional<T> or Option[T]

Open wsargent opened this issue 7 years ago • 3 comments

In many places, the Java WSRequest and WSResponse still use methods which return null:

public interface StandaloneWSRequest {
    String getUsername();

    String getPassword();

    WSAuthScheme getScheme();

    WSSignatureCalculator getCalculator();

    Duration getRequestTimeoutDuration();

    boolean getFollowRedirects();

    String getContentType();
}

And they should return Optional<String> etc where appropriate.

wsargent avatar Jun 13 '17 00:06 wsargent

Addressed by https://github.com/playframework/play-ws/pull/129

wsargent avatar Jun 13 '17 00:06 wsargent

hi, is this one up for picking or is it already fixed by #129 ?

dmitraver avatar Oct 01 '17 09:10 dmitraver

Hey, @dmitraver,

it was already addressed by #129.

Best.

marcospereira avatar Oct 03 '17 22:10 marcospereira