play-slick icon indicating copy to clipboard operation
play-slick copied to clipboard

slick-context documented but not used

Open arobertn opened this issue 10 years ago • 0 comments

Please correct me if I'm wrong, but it appears that the recommended configuration of an Akka "slick-context" here: https://github.com/playframework/play-slick/wiki/ScalaSlickThreads

is not actually used for anything. According to the docs here:

https://www.playframework.com/documentation/2.3.x/ThreadPools

such custom execution contexts need to be explicitly referenced somewhere in the code (as in, 'Akka.system.dispatchers.lookup("my-context")') in order to be used. I can find no such code anywhere in play-slick (although there was at one time) Instead, there is the SlickExecutionContext object which creates a threadpool executor based on min/max DB connections.

In any case it would be good to clearly document how the threading and connections are managed. The relation between the BoneCP configuration, Play's Akka default dispatcher, and this play-slick threadpool are not particularly clear.

arobertn avatar Feb 17 '15 12:02 arobertn