play-grpc icon indicating copy to clipboard operation
play-grpc copied to clipboard

Duplicate ClassicActorSystemProvider binding when using with Play 2.8.3

Open octonato opened this issue 5 years ago • 2 comments

Play 2.8.3 provides already a binding for akka.actor.ClassicActorSystemProvider which causes the following error:

A binding to akka.actor.ClassicActorSystemProvider was already configured at play.grpc.ClassicActorsystemProviderModule.<init>(ClassicActorsystemProviderModule.scala:13):
[error] Binding(interface akka.actor.ClassicActorSystemProvider to ProviderConstructionTarget(class play.api.libs.concurrent.ActorSystemProvider)) (via modules: com.google.inject.util.Modules$OverrideModule -> play.api.inject.guice.GuiceableModuleConversions$$anon$4).

Only affects Play users (Java and Scala) using Guice.

Workaround

Users upgrading to Play 2.8.3 can disable the play-grpc Guice module providing the binding with:

play.modules.disabled += "play.grpc.ClassicActorsystemProviderModule"

See PR #309

octonato avatar Oct 30 '20 08:10 octonato

@octonato IIUC this is fixed, right? Can we close the issue already?

ignasi35 avatar Feb 10 '21 09:02 ignasi35

As far as I can tell the issue persists in Play 2.8.8/Play-grpc 1.1.1 when using guice

bmo-at avatar Oct 18 '21 12:10 bmo-at