player-03

Results 275 comments of player-03

Ok, submitted a bunch of changes. Check them out and see if they work for you.

Oh yeah, definitely keep both in project.xml. Those values still get passed to build.gradle. We're only removing them from the manifest because they're redundant there.

Didn't see a reason to mess with it, I guess. Other than at really low numbers, I've never run into a case where `minSdkVersion` made a noticeable difference.

Looks like we were already doing this: ```haxe private function handleFocusEvent(event:FocusEvent):Void { if (textInputEnabled) { if (event.relatedTarget == null || isDescendent(cast event.relatedTarget)) { Timer.delay(function() { if (textInputEnabled) textInput.focus(); }, 20);...

I wonder if the function name could be shorter. - `refocusTextInput` - `restoreFocusAfterDelay` - `restoreInputFocus` But there's always a trade-off. Longer names are explicit, shorter names are easier to remember....

Apparently this breaks PiratePig. Something to do with uploading textures, which is odd because none of these changes should have affected much of anything. I was hoping to get this...

Ok, so it turns out I messed up the [tagged pointer](https://source.android.com/docs/security/test/tagged-pointers) workaround. PiratePig works fine when I include it. That said, I still don't plan to merge just yet, in...

I considered suggesting `Path.addTrailingSlash()`, but I don't know if it's worth importing `Path` just for that. Honestly it looks good to me the way it is.

Huh, the web UI didn't allow me to customize the commit message. I would've added that I cleaned up a bit in the process of merging. No need to use...

That's what I was thinking. I know some startup files still go through the `#if (haxe_ver > 3.3) Sys.programPath() #else ...` rigamarole, but given that we don't actually test it,...