engine icon indicating copy to clipboard operation
engine copied to clipboard

Published 20 hours ago • verified publisher icon playcanvas

Clear wasm module global

Open slimbuck opened this issue 2 years ago • 1 comments

Glb-parser currently fails to work with draco because it looks at window global for wasm module.

This PR changes WasmModule to clear the global module object on window.

slimbuck avatar Aug 09 '22 18:08 slimbuck

Could this cause issues on multi engine instances apps if it clears a global?

yaustar avatar Aug 09 '22 20:08 yaustar

Could this cause issues on multi engine instances apps if it clears a global?

Nope. I'd like to add support for multiple applications or wasm instances, but that won't be affected by this change.

slimbuck avatar Aug 10 '22 08:08 slimbuck