play-with-docker.github.io icon indicating copy to clipboard operation
play-with-docker.github.io copied to clipboard

Published 20 hours ago • verified publisher icon play-with-docker

A link in Task 3 on the lab is incorrect

Open maithuvenkatesh opened this issue 4 years ago • 10 comments

The link provided in Step 2 of Task 3 of this lab in the section called "Test the new version" is incorrect.

This is the link's URL:

http://ip172-18-0-9-bq7qj75im9m000e1aaug-8080.direct.labs.play-with-docker.com/

Seems like it should be port 80 not 8080

http://ip172-18-0-9-bq7qj75im9m000e1aaug-80.direct.labs.play-with-docker.com/

maithuvenkatesh avatar Apr 10 '20 00:04 maithuvenkatesh

@maithuvenkatesh would you like to send a PR to fix it?

marcosnils avatar Apr 10 '20 01:04 marcosnils

@maithuvenkatesh I have gone through the tutorial, it is working without any issues. @marcosnils we clone this issue. I am confident that I haven't seemed any issue

jinnabaalu avatar Jun 11 '20 07:06 jinnabaalu

I have had the same issue. The link in the .md file looks to be asking for port 80 but when I click on it in the tutorial it takes me to http://ip172-18-0-22-bsvbrg5im9m000andmog-8080.direct.labs.play-with-docker.com/

https://github.com/play-with-docker/play-with-docker.github.io/blame/master/_posts/2016-10-25-beginner-linux.markdown#L394

HarryEMartland avatar Aug 20 '20 18:08 HarryEMartland

Hi! Sorry been away for quite a while it seems. @marcosnils I did looks into it and there wasn't an obvious fix. I need to delve into it a bit more. I think it's an issue with relative links. Thanks for confirming @HarryEMartland! Feel free to take a stab at fixing it. I won't be able to look into it in the next week.

maithuvenkatesh avatar Aug 20 '20 18:08 maithuvenkatesh

Would it be easier to change the commands to set the port to 8080?

HarryEMartland avatar Aug 20 '20 18:08 HarryEMartland

Encountered the same issue. Interesingly, I also noticed the corrected link does work in Chromium, but not in Firefox. Any Firefox user experienced the same issue?

vollkorn1982 avatar Apr 13 '24 15:04 vollkorn1982

I traced the problem down to the JavaScript implementation in pwd.js, but I cannot find where pwd.js's repository is to make a pull request against. Anyone know where to find it?

vollkorn1982 avatar Apr 13 '24 16:04 vollkorn1982

The repo is here https://github.com/play-with-docker/sdk

sent from mobile

Em sáb., 13 de abr. de 2024, 13:02, vollkorn1982 @.***> escreveu:

I traced the problem down to the JavaScript implementation in pwd.js @.***/dist/pwd.js>, but I cannot find where pwd.js's repository is to make a pull request against. Anyone know where to find it?

— Reply to this email directly, view it on GitHub https://github.com/play-with-docker/play-with-docker.github.io/issues/205#issuecomment-2053687527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMBLWWIFUQJB532TQXOEKLY5FJHVAVCNFSM4MFDXB2KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBVGM3DQNZVGI3Q . You are receiving this because you were mentioned.Message ID: @.*** com>

marcosnils avatar Apr 13 '24 16:04 marcosnils

It's an upstream bug, follow progress in this issue: https://github.com/play-with-docker/sdk/issues/56

vollkorn1982 avatar Apr 15 '24 06:04 vollkorn1982

Hello! I've observed this issue as well and have created a fix for it. The problem lies in the way the links are dynamically generated. I've submitted a pull request to address this (https://github.com/play-with-docker/sdk/pull/57)

FeSuert avatar Apr 29 '24 10:04 FeSuert