community-edition icon indicating copy to clipboard operation
community-edition copied to clipboard

Update clickhouse to 22.4.2.1

Open paskal opened this issue 2 years ago • 10 comments

That version supports ARM.

paskal avatar Apr 23 '22 11:04 paskal

@ukutaht would you be so kind as to review this change please?

paskal avatar Apr 30 '22 21:04 paskal

Thanks! I'll cut a new self-hosted release this/next week. I'll upgrade the dependencies then.

ukutaht avatar May 02 '22 06:05 ukutaht

@ukutaht, do you think anything will break when it is merged? I believe that MR is harmless and won't change anything for the worse but will improve the quality of life for ARM users.

paskal avatar May 12 '22 14:05 paskal

@ukutaht gentle ping.

paskal avatar Jun 06 '22 18:06 paskal

@ukutaht, another gentle ping for reviewing and merging this backwards-compatible change which doesn't break anything for anyone. I've removed the workaround for ARM problems from this PR as it's fixed in Clickhouse master and eventually will end up in the newer Clickhouse image.

paskal avatar Jun 15 '22 21:06 paskal

A little clarification: everything works completely fine for me, I've figured out a way to make it work under ARM, and I'm happy with it. The only thing which bugs me is that following the guide before this PR is merged gives you a setup which doesn't work under ARM, and the user has to go into GitHub issues and read a bunch before figuring out what has to be done.

paskal avatar Jun 15 '22 21:06 paskal

Can confirm it works.

BenRoe avatar Jun 21 '22 13:06 BenRoe

When new update, because all problem plausible/analytics:latest It would be great if you could fully update this repo now. Because it doesn't work @ukutaht

productdevbook avatar Jul 11 '22 09:07 productdevbook

@ukutaht another gentle ping for reviewing and merging this PR.

paskal avatar Jul 22 '22 02:07 paskal

@ukutaht another ping here - ARM support would be amazing and this PR appears to work fine.

micahlt avatar Aug 02 '22 03:08 micahlt

Hello @ukutaht, I wonder if there is any chance of this and https://github.com/plausible/docs/pull/240 PRs being merged?

paskal avatar Aug 26 '22 21:08 paskal

Pinging @ruslandoga with this one. He'll be cutting the next release so we'll update the CH version then as well.

ukutaht avatar Sep 01 '22 14:09 ukutaht

@ruslandoga, please review once more; it should be good to go now. Thank you!

paskal avatar Sep 12 '22 17:09 paskal

I can't merge it, unfortunately. I hope you'll hit the button as well. UPD: nvm, I've understood you don't have the merge rights yet.

paskal avatar Sep 12 '22 17:09 paskal

@paskal thank you!

ruslandoga avatar Sep 13 '22 07:09 ruslandoga

@paskal Awesome, thanks for the PR. I wanted to set this up on my Pi. You mentioned it works for you. Can you by chance send me a config of yours? Currently the plausible/analytics:latest is still not ARM based and there are no ARM images here yet https://hub.docker.com/r/plausible/analytics/tags?page=1

DennisLoska avatar Sep 14 '22 10:09 DennisLoska

v1.5.0 will not have ARM yet but it's something we're looking at for the next release

ukutaht avatar Sep 14 '22 13:09 ukutaht

@ukutaht Alright thanks! I used another image form another PR here regarding ARM and I can confirm that it is working on a Raspberry Pi 4 just changed the pausible image for that to an ARM based one. Thank you for this awesome tool :+1:

DennisLoska avatar Sep 14 '22 13:09 DennisLoska

@DennisLoska, just build it on the same Pi yourself. Here is the command: git clone https://github.com/plausible/analytics.git && cd analytics && docker build --pull -t plausible/analytics:latest .

I personally use the tag plausible/analytics:arm-manual-build to make sure I won't accidentally break Plausible by pulling the wrong architecture from the DockerHub.

paskal avatar Sep 14 '22 16:09 paskal

@paskal Thank you so much!

DennisLoska avatar Sep 14 '22 16:09 DennisLoska