analytics icon indicating copy to clipboard operation
analytics copied to clipboard

Remove Timex from Plausible.Timezones

Open ruslandoga opened this issue 1 year ago • 1 comments

Continues https://github.com/plausible/analytics/pull/4338

Changes

This PR continues the removal of Timex by updating Plausible.Timezones to use stdlib instead of Timex.

This includes:

Unlike the previous PRs this one requires updates to the tests since Timex logic is wrong:

  • Timex does not handle gaps in wall time: https://github.com/plausible/analytics/pull/3899#discussion_r1525956437
  • Timex confuses + and - in Etc/GMT timezones: https://github.com/bitwalker/timex/issues/685

Tests

  • [x] Automated tests have been updated

Changelog

  • [x] No need to update changelog.

Documentation

  • [x] This change does not need a documentation update

Dark mode

  • [x] This PR does not change the UI

ruslandoga avatar Mar 15 '24 01:03 ruslandoga

Preview environment👷🏼‍♀️🏗️
PR-3899

github-actions[bot] avatar Aug 23 '24 09:08 github-actions[bot]