analytics icon indicating copy to clipboard operation
analytics copied to clipboard

Fix the timeseries for the 7d period with hour interval

Open krisbuist opened this issue 2 years ago • 3 comments

When bucketing on hour, the current day needs to be taken into account for as well. The query executed on the database already contained the correct results, but they were omitted because too few buckets were selected

Changes

Please describe the changes made in the pull request here.

Below you'll find a checklist. For each item on the list, check one option and delete the other.

Tests

  • [X] Automated tests have been added
  • [ ] This PR does not require tests

Changelog

  • [X] Entry has been added to changelog
  • [ ] This PR does not make a user-facing change

Documentation

  • [ ] Docs have been updated
  • [X] This change does not need a documentation update

Dark mode

  • [ ] The UI has been tested both in dark and light mode
  • [X] This PR does not change the UI

krisbuist avatar Sep 22 '23 11:09 krisbuist

BundleMon

Unchanged files (7)
Status Path Size Limits
:white_check_mark: static/js/dashboard.js
318.59KB -
:white_check_mark: static/js/app.js
40.32KB -
:white_check_mark: static/css/app.css
14.46KB -
:white_check_mark: static/js/embed.host.js
5.58KB -
:white_check_mark: static/js/embed.content.js
5.08KB -
:white_check_mark: tracker/js/plausible.js
742B -
:white_check_mark: static/js/applyTheme.js
314B -

No change in files bundle size

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history

bundlemon[bot] avatar Sep 22 '23 11:09 bundlemon[bot]

I'm wondering if this is actually a relevant fix or that the previous behaviour was intentional. For me, the behaviour from this PR feels more intuitive, so that the "7d" period also shows the current day. But I might be overlooking something

krisbuist avatar Nov 22 '23 08:11 krisbuist

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 22 '24 14:03 CLAassistant