analytics
analytics copied to clipboard
fix: site permission check
Changes
This pull request correct the role of super_admin in Plausible.AuthorizeSiteAccess.
Tests
- [ ] Automated tests have been added
- [x] This PR does not require tests
Changelog
- [ ] Entry has been added to changelog
- [x] This PR does not make a user-facing change
Documentation
- [ ] Docs have been updated
- [x] This change does not need a documentation update
Dark mode
- [ ] The UI has been tested both in dark and light mode
- [x] This PR does not change the UI
BundleMon
Unchanged files (7)
| Status | Path | Size | Limits |
|---|---|---|---|
| :white_check_mark: | static/css/app.css |
492.34KB | - |
| :white_check_mark: | static/js/dashboard.js |
304.55KB | - |
| :white_check_mark: | static/js/app.js |
12.31KB | - |
| :white_check_mark: | static/js/embed.host.js |
5.58KB | - |
| :white_check_mark: | static/js/embed.content.js |
5.06KB | - |
| :white_check_mark: | tracker/js/plausible.js |
742B | - |
| :white_check_mark: | static/js/applyTheme.js |
314B | - |
No change in files bundle size
Final result: :white_check_mark:
View report in BundleMon website ➡️
Thanks @renbaoshuo!
Why is this change necessary?
Why is this change necessary?
When a user has a site-level view permission (e.g. being invited as a "Viewer"), if the user is also a super_admin, he will not be able to make changes to the site settings.
Closing as this behaviour is not intended to be used outside of our cloud deployment.