analytics icon indicating copy to clipboard operation
analytics copied to clipboard

Published 20 hours ago • verified publisher icon plausible

Reset goal stats

Open vinibrsl opened this issue 2 years ago • 1 comments

Changes

This pull request adds new button in Site > Settings > Goals to reset goals by deleting all related events. This was suggested in https://github.com/plausible/analytics/discussions/186.

Screen Shot 2022-07-12 at 7 54 04 PM

Tests

  • [x] Automated tests have been added

Changelog

  • [x] Entry has been added to changelog

Documentation

  • [x] Docs have been updated (link: https://github.com/plausible/docs/pull/247)

Dark mode

  • [x] The UI has been tested both in dark and light mode

vinibrsl avatar Jul 12 '22 23:07 vinibrsl

Nice one @vinibrsl, thanks!

metmarkosaric avatar Jul 18 '22 11:07 metmarkosaric

This was a fun exercise, but I would like to discuss first whether hard deletes is the right way here. The use-case for deleting data is much broader than this PR:

People often want to remove tracking from a page whose URL was supposed to stay secret, for example. Or maybe a bot generated a bunch of bad data that needs to be cleared. Or maybe they sent data from a dev environment and want to clear that.

Beyond resetting goals, the more common use-case would be:

  1. Filter your dashboard by some filters
  2. Remove only the data that matches those filters

Currently we do hard deletes through the database CLI for these manually. I'd love for customers to be able to do it themselves but giving people the power to remove data is dangerous with hard deletes. I can imagine our support being swarmed by people wanting to recover data they accidentally deleted. It should be possible to UNDO a delete for a while after it was run.

Basically, I think we need to implement soft deletes before shipping this feature.

ukutaht avatar Aug 10 '22 11:08 ukutaht