indoor-navigation-system icon indicating copy to clipboard operation
indoor-navigation-system copied to clipboard

C++ code has been committed without being static analyzed

Open platisd opened this issue 7 years ago • 5 comments

Description

As an INS developer I do not want to have code that has not been approved by a static analysis tool committed to one of the main branches. Therefore, I would like to make sure that my code is verified by a static analysis tool before being allowed to merge.

A good relevant post to read can be found here.

Definition of Done

  • A static analysis tool (e.g. cppcheck) is run by Travis and verifies the submitted code before allowing to merge
  • Static analysis script is present in the c++ source folders, e.g. server/run_static_analysis.sh
  • Current problems, discovered by static analysis tool, are addressed
  • (Optional) Try to run the static analysis check in parallel with the rest of the build

platisd avatar Jan 18 '18 21:01 platisd