legacy-cli
legacy-cli copied to clipboard
platformsh
Show usage per database.
Customer reported a bug in the new version. That caused him to see the same numbers for every database/relation. I had to add a new table to show the database sizes because we can't directly compare that against the allocated size. On the bright side: this does make it very clear where the storage usage is coming from.
Customer reported a bug in the new version. That caused him to see the same numbers for every database/relation.
Sorry.. what's the bug?
I removed the colouring on the database table, because we don't want to alarm the customer for no reason. There is nothing wrong with a customer having a single database ;-)
Do note that this also fixes a UI bug that was introduced in the previous merge to development.
Still scratching my head over what the UI bug is. Do you mean the per-relationship usage? That is/was misleading, as the disk exists independently of the relationships, so you'd need to see the full usage on the disk regardless of which relationship is used. Breaking down the usage per schema/table as well as showing the full usage is a useful feature.
The problem is that you used to be able to specify which database you wanted to see the size for.
We changed the way the size is calculated to be more accurate (file based in stead of innodb based). And I forgot that you could specify a specific database.
As a result, each database shows the total size.
I may have gone a little too far in fixing a bug by adding a feature that changes the UI. But that was because I discovered that comparing the allocated space to 1 database, is like comparing apples to oranges.
And that last one was indeed a problem in the previous version as well.
Hence: this is a feature, to solve a bug, which was discovered while fixing another bug. :)
Sorry I made it a little confusing
On Fri, 12 Jul 2019, 18:11 Patrick Dawkins, [email protected] wrote:
Still scratching my head over what the UI bug is. Do you mean the per-relationship usage? That is/was misleading, as the disk exists independently of the relationships, so you'd need to see the full usage on the disk regardless of which relationship is used. Breaking down the usage per schema/table as well as showing the full usage is a useful feature.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/platformsh/platformsh-cli/pull/816?email_source=notifications&email_token=AA26OE54W5INDCM63B5DURLP7CUKRA5CNFSM4H33XOBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ2GIOY#issuecomment-510944315, or mute the thread https://github.com/notifications/unsubscribe-auth/AA26OE3DEWASR4GREAE7TBTP7CUKRANCNFSM4H33XOBA .
@pjcdawkins Do you want me to reclassify this as a feature request to merge this?