cli icon indicating copy to clipboard operation
cli copied to clipboard

Shell config warning is very noisy

Open pjcdawkins opened this issue 3 years ago • 2 comments

"checkShellConfigLeftovers" sends a big warning after every command, about config left over in a shell config file, even though it's not doing any harm

also getting rid of this config unfortunately removes the "p" alias

suggestions (any or all):

  • make it softer (not "Warning")
  • suggest to auto-remove the config so there's no unnecessary manual work
  • only show the warning once, or once a week
  • move it to the beginning not the end of the command output (so it's easier to read the desired output)
  • allow the warning to be suppressed with config / an environment variable

pjcdawkins avatar Jan 14 '23 10:01 pjcdawkins

  • make it softer (not "Warning")

Would this mean just removing the "Warning:" prefix, or also an update in the wording?

  • suggest to auto-remove the config so there's no unnecessary manual work

We've decided against that, as it might break the local configuration of the user, in case the user has manually altered that part.

  • only show the warning once, or once a week

We could switch to displaying this once every day, I think that's the a good improvement

  • move it to the beginning not the end of the command output (so it's easier to read the desired output)

All non-blocking warnings have been pushed to the end (same happens with the update prompt), to avoid confusing the user before they end their command. Why would moving it to the beginning would help?

  • allow the warning to be suppressed with config / an environment variable

Definitely a good idea as well.

I think we can start with lowering the frequency of the appearance of the message and allowing the user to disable this with a config, what do you think @pjcdawkins @lolautruche?

akalipetis avatar Jan 16 '23 06:01 akalipetis

I agree with your suggestion @akalipetis

lolautruche avatar Jan 16 '23 14:01 lolautruche