platformio-home
platformio-home copied to clipboard
Use backend system to determine path separator
Here is a sample PR which allows the frontend to use the backend PIO's system type to determine if it's running in Windows or not. This affects the type of path separator that is used.
In a setup where there is a difference between the frontend system and backend (for example, Windows 11 client, WSL2 backend, or VS Code Remote), it doesn't make sense to detect the OS on the frontend, and today you are unable to create projects and navigate correctly because of this.
Caveats:
- I've done testing on Win11 + WSL2, Win11 local. I don't have a Linux system with a desktop however but have simulated it to ensure the values loaded correctly
- I'm not great at React, and never touched Redux before, so I consider this a working example, but I can't say if it's a good contribution in the current state.
- It assumes a pretty happy path; I don't know enough about the application to know if there are situations where the app state hasn't loaded but the user is able to perform other actions (it seems like a very early bootstrap step)
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: cbundy
:x: =
= seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
This issue has been automatically marked as stale because it has not had recent activity. Please provide more details or it will be closed if no further activity occurs. Thank you for your contributions.
Please unstale and merge.
@spali I noticed the maintainers for this project are in Ukraine, so it may not be something that can be turned around in a short period of time.
Makes sense, but didn't want to stress about the merging, was more in hope to get the bot to unstale the issue.
unstale please bot
Ran into this issue today. Hopefully the bot marks as unstale.
Please keep this issue open
Ran into this issue today. Please keep this issue open.
...
bump, this is still relevant
bumping again
This build is failing, I don't have the same environment to get this working - plus I would only consider it if the owners of the repository are onboard with this before I spend more time on it.
Is there any progress on this PR?
I'm not sure there is engagement from the maintainers to take it forward. I'm not currently using PIO so if it's needed then I suggest someone else gets this fix working again, I don't have capacity currently, sorry
@ivankravets requesting your input here.
I am seeing build failures on the checks/action on a branch from develop with no changes from upstream.
I will try and push forward with this but only if I know that there's a chance that the change will be accepted - please let me know if this is not something you have time for and I will leave this alone.
Sorry for this issue. We don’t plan to fix it. We work on the new UI for PlatformIO that will be the part of PlatformIO Core 7.0.
No problem, thanks for getting in touch @ivankravets. We'll patiently wait for the next version.
I'll be closing this PR as well