platform-espressif32 icon indicating copy to clipboard operation
platform-espressif32 copied to clipboard

Published 20 hours ago • verified publisher icon platformio

add board definitions for unphone ESP32 and ESP32S3 devices

Open hamishcunningham opened this issue 2 years ago • 10 comments

Board definitions for unphone boards: see https://iot.unphone.net/ and https://unphone.net/ for details.

hamishcunningham avatar Aug 03 '22 14:08 hamishcunningham

Hi @hamishcunningham ! Thanks for the PR. Please see my comments above.

valeros avatar Aug 03 '22 17:08 valeros

Just to add, the PR to add variants to arduino-esp32 is now https://github.com/espressif/arduino-esp32/pull/7109

garethhcoleman avatar Aug 10 '22 16:08 garethhcoleman

Our pull request on arduino-esp32 has now been accepted https://github.com/espressif/arduino-esp32/pull/7109 and we've checked and revised all the sizes, so hopefully this is good to go? Tnx!

hamishcunningham avatar Aug 12 '22 10:08 hamishcunningham

Hi @hamishcunningham , thanks for the updates. Please review my comments above.

valeros avatar Aug 12 '22 10:08 valeros

Thanks for your patience reviewing our submission @valeros!!

In addition to the changes you highlighted I have an additional question.

"flash_mode": "dio", is this correct? On more careful review, other boards like ESP32-S3-DevKitC-1 have it as qio, indeed I see a recent fix that changed this.

Thanks again!

garethhcoleman avatar Aug 12 '22 12:08 garethhcoleman

"flash_mode": "dio", is this correct?

It seems you're using the QIO bootloader in the PR to the Arduino core, so it should be synchronized here as well.

valeros avatar Aug 12 '22 12:08 valeros

hi @valeros I think 648b105405a5b04947d47873228b396cd0b6f65c addresses your comments? Tnx! H

hamishcunningham avatar Aug 14 '22 11:08 hamishcunningham

LGTM, the PR will be merged once a new stable version of ESP32 core is released.

valeros avatar Aug 25 '22 17:08 valeros

@valeros thank you, appreciate the update and glad that we have been able to address issues.

good vibes to you!

G

garethhcoleman avatar Aug 25 '22 18:08 garethhcoleman

hi @valeros can this be merged now that 2.0.5 of the core is released? tnx! h

hamishcunningham avatar Sep 17 '22 16:09 hamishcunningham

Thanks for the PR, merged! The boards will be available in the upcoming release of the dev-platform.

valeros avatar Sep 26 '22 18:09 valeros

Thank you!

On Mon, 26 Sep 2022, 19:41 Valerii Koval, @.***> wrote:

Thanks for the PR, merged! The boards will be available in the upcoming release of the dev-platform.

— Reply to this email directly, view it on GitHub https://github.com/platformio/platform-espressif32/pull/870#issuecomment-1258455229, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBRBFC2IBX5JI4AMIOFJH3WAHU43ANCNFSM55PFAIIA . You are receiving this because you were mentioned.Message ID: @.***>

hamishcunningham avatar Sep 26 '22 19:09 hamishcunningham